Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-hubspot-native: enable the property history configuration #2258

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Jan 9, 2025

Description:

This makes the property history configuration active, so that users can optionally opt-in to capturing property history.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

This makes the property history configuration active, so that users can
optionally opt-in to capturing property history.
HubSpot APIs will sometimes return random 500 errors, or timeouts. The connector
often needs to string together thousands of successful API calls to work through
a delayed fetch of a time window, so these random errors causing a connector
restart results in a lot of downtime and wasted work.

This adds some retry logic to retry these requests a few times before crashing
the connector.
Copy link
Member

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit c3fdfbb into main Jan 9, 2025
71 of 81 checks passed
@williamhbaker williamhbaker deleted the wb/hsn-no-history branch January 9, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants